Skip dependencies installation if explicit is installed PLUS#16654
Closed
tldahlgren wants to merge 1 commit intospack:developfrom
Closed
Skip dependencies installation if explicit is installed PLUS#16654tldahlgren wants to merge 1 commit intospack:developfrom
tldahlgren wants to merge 1 commit intospack:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue raised in slack where a package that is already installed but has uninstalled dependencies does NOT get re-installed.
Todd has added the use of pre- (versus post-) order traversals to facilitate pruning installed dependencies.
TODO
_update_installedto take a package or task and use it where post-order allowed us to just add an installed package to theinstalledlist