Bugfix/tests: Check presence not equality for rpath changes#16637
Merged
alalazo merged 2 commits intospack:developfrom May 20, 2020
Merged
Bugfix/tests: Check presence not equality for rpath changes#16637alalazo merged 2 commits intospack:developfrom
alalazo merged 2 commits intospack:developfrom
Conversation
tldahlgren
added
rpath
tests
tldahlgren
changed the title
tldahlgren
requested review from
alalazo and
tgamblin
and removed request for
becker33 and
scheibelp
alalazo
approved these changes
May 20, 2020
Member
|
Restarted failing tests, just waiting for them to finish successfully |
Contributor
Author
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16636
The tests currently expect equality, which is a problem if there are other libraries in the
rpath. This PR instead checks for presence of the changed lib paths in the output since some compilers add rpaths.