Conversation
adamjstewart
approved these changes
May 12, 2020
Member
adamjstewart
left a comment
There was a problem hiding this comment.
Want to be an official "maintainer" for the clingo package? 😜
`clingo` has some undocumented dependencies: - `bison`, for which the default macos version is too old - `re2c`, which isn't always available Also, the python installation was not set up properly. Clingo by default does an install in `~/.local`, so we need to disable that and add a few other options to get things right. - [x] add `bison` dependency - [x] add `re2c` dependency - [x] make `doxygen` dependency optional (and patch if needed) - [x] add options to fix `python` build - [x] make python build optional but on by default
550793b to
69091ac
Compare
Member
Author
done |
alalazo
approved these changes
May 12, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clingohas some undocumented dependencies:bison, for which the default macos version is too oldre2c, which isn't always availableAlso, the python installation was not set up properly. Clingo by default
does an install in
~/.local, so we need to disable that and add a fewother options to get things right.
bisondependencyre2cdependencydoxygendependency optional (and patch if needed)pythonbuild