spack.relocate: further coverage for ELF related functions#16585
Merged
becker33 merged 11 commits intospack:developfrom May 26, 2020
Merged
spack.relocate: further coverage for ELF related functions#16585becker33 merged 11 commits intospack:developfrom
becker33 merged 11 commits intospack:developfrom
Conversation
alalazo
force-pushed
the
qa/relocate_elf_binaries
branch
2 times, most recently
from
1c55aa3 to
3725fdc
Compare
becker33
requested changes
May 20, 2020
| _replace_prefix_text(file, orig_install_prefix, new_install_prefix) | ||
| for orig_dep_prefix, new_dep_prefix in new_prefixes.items(): | ||
| _replace_prefix_text(file, orig_dep_prefix, new_dep_prefix) | ||
| _replace_prefix_text(file, orig_layout_root, new_layout_root) |
Member
There was a problem hiding this comment.
Why do replace the layout root for text files but not binary files? Seems like this should be the same for both.
Member
Author
There was a problem hiding this comment.
For what is worth in this PR I didn't change any logic, only added unit tests, docstrings and made naming consistent for ELF related functions. If it is fine with you I can add a TODO like I did above for the number of arguments, and work on that in a following PR (so not to mix the trivial refactor done here with a change in logic).
Also, maybe @gartung has more to say on the rationale.
gartung
approved these changes
May 20, 2020
Also fixed a possible bug that was issuing spurious warning when a file was relocated successfully
alalazo
force-pushed
the
qa/relocate_elf_binaries
branch
from
ce8746c to
b9de3b2
Compare
becker33
approved these changes
May 26, 2020
Member
Author
|
Thanks @becker33 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
spack.relocate