Skip to content

Update py-pint versions#16537

Merged
alalazo merged 6 commits intospack:developfrom
lpritch-lanl:pint-0.11
May 13, 2020
Merged

Update py-pint versions#16537
alalazo merged 6 commits intospack:developfrom
lpritch-lanl:pint-0.11

Conversation

@lpritch-lanl
Copy link
Copy Markdown
Contributor

No description provided.

@lpritch-lanl lpritch-lanl changed the title Updated the prefered version to 0.11 and added releases 0.9-0.10.1 Update py-pint versions May 8, 2020
Copy link
Copy Markdown
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the following dependencies:

python_requires = >=3.6
install_requires = setuptools
setup_requires = setuptools; setuptools_scm

Also, is there a reason to switch from PyPI to GitHub?

@lpritch-lanl
Copy link
Copy Markdown
Contributor Author

Missing the following dependencies:

python_requires = >=3.6

I believe I have fixed this.

install_requires = setuptools
setup_requires = setuptools; setuptools_scm


I don't know how to resolve these. I have a depends_on('py-setuptools') statement in the package.py file, but could not locate a setuptools-scm package.

Also, is there a reason to switch from PyPI to GitHub?

I originally had issues downloading from PyPI that I resolved. Switched it back to PyPI.

@lpritch-lanl lpritch-lanl marked this pull request as draft May 11, 2020 20:03
@adamjstewart
Copy link
Copy Markdown
Member

I don't know how to resolve these. I have a depends_on('py-setuptools') statement in the package.py file, but could not locate a setuptools-scm package.

There is a py-setuptools-scm package, you just need to add a build dependency on that.

…e all Python packages have this dependency
@lpritch-lanl lpritch-lanl marked this pull request as ready for review May 12, 2020 23:43
@alalazo alalazo merged commit 043d507 into spack:develop May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants