Travis use bionic as default for Linux#16521
Merged
tgamblin merged 8 commits intospack:developfrom May 12, 2020
Merged
Conversation
alalazo
force-pushed
the
qa/update_travis
branch
9 times, most recently
from
2d91e3d to
ae7da61
Compare
tgamblin
requested changes
May 12, 2020
| tar -C ${KCOV_ROOT} -xzvf ${KCOV_ROOT}/${KCOV_VERSION}.tar.gz; | ||
| mkdir -p ${KCOV_ROOT}/build; | ||
| cd ${KCOV_ROOT}/build && cmake -Wno-dev ${KCOV_ROOT}/kcov-${KCOV_VERSION} && cd - ; | ||
| make -C ${KCOV_ROOT}/build && sudo make -C ${KCOV_ROOT}/build install; |
Member
There was a problem hiding this comment.
Can we use spack for this? We should if possible. In general I think we should prefer to dogfood even in tests, unless there’s a reason not to.
Member
Author
There was a problem hiding this comment.
If we go all the way down this means installing:
kcov@38%[email protected] build_type=RelWithDebInfo arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected]~doc+ncurses+openssl+ownlibs patches=1c540040c7e203dd8e27aa20345ecb07fe06570d56410a24a266ae570b1c4c39 ~qt arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected]~symlinks+termlib arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected]+systemcerts arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected]+cpanm+shared+threads arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected]+optimize+pic+shared arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected]~darwinssl~gssapi~libssh~libssh2~nghttp2 arch=linux-ubuntu18.04-broadwell
which may take a long time under CI, unless we want to register most of the things as externals but that would complicate a bit the setup and defeat the idea of dogfooding. If we only had binary packages... 🙂
Member
There was a problem hiding this comment.
yeah ok let's hold off until we have binaries. Gosh that'll be nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications:
bionicas a default (xenialused for Python 3.5,trustyfor Python 2.6)kcovis built only for tests that upload coverage resultsOverall with this we shave 3-4 mins. on each run and add an additional run of about 3 min. For some reason
kcov38 fails forwarding output when used with Python unit tests, so I used v34 for that and v38 (latest) for shell testing. Previously we were using v25.