caffe: fixed build error#16520
Merged
adamjstewart merged 2 commits intospack:developfrom May 12, 2020
Merged
Conversation
Contributor
tkameyama
commented
May 8, 2020
tkameyama
commented
- caffe depemndents hdf5 +hl +cxx
- change caffe dependency of opencv
- opencv 3.2 required old cmake
adamjstewart
reviewed
May 8, 2020
|
|
||
| # Optional dependencies | ||
| depends_on('[email protected]+core+highgui+imgproc', when='+opencv') | ||
| depends_on('[email protected]+core+highgui+imgproc~vtk~videoio~gtk~python', when='+opencv') |
Member
There was a problem hiding this comment.
caffe doesn't work if you link to opencv+vtk... or you just want to change the default?
Contributor
Author
There was a problem hiding this comment.
[email protected]+vtk... did not build.
I'm backport to build openvc.
| tag="{0}".format(cv), | ||
| when='@{0}+cuda'.format(cv)) | ||
|
|
||
| depends_on('cmake@:3.11', when='@:3.2', type='build') |
Contributor
Author
There was a problem hiding this comment.
cmake 3.12 is changed python detection code.
I'm backport for cmake 3.12 or later.
added 2 commits
May 12, 2020 11:17
caffe dependency is changed.
backport to opencv errors.
adamjstewart
approved these changes
May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.