update visit package with 3.1.1 release and add comments#16498
update visit package with 3.1.1 release and add comments#16498tgamblin merged 3 commits intospack:developfrom
Conversation
|
note: i also will add develop as an option as part of this PR. |
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Want to be an official "maintainer" for the package?
|
thanks @adamjstewart -- I also added myself as maintainer |
| root_cmakelists_dir = 'src' | ||
|
|
||
| @when('@3.0.0:3.0.1') | ||
| @when('@3.0.0:3.999,develop') |
There was a problem hiding this comment.
Do we have to run recmake_visit.sh when this is patched?
I get the following error:
1 error found in build log:
1662 --
1663
1664 Use recmake_visit.sh or search for `CMAKE_INVOKE' in CMakeCache.txt to re-run CMake with the same arguments
1665
1666
1667 -- Configuring done
>> 1668 CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
1669 Please set them or make sure they are set and tested correctly in the CMake files:
1670 OPENGL_glu_LIBRARY (ADVANCED)
1671 linked by target "avtplotter_ser" in directory /tmp/axel/spack-stage/spack-stage-visit-develop-an2jjizo3id7bdttlm3p4ou3673zv4nh/spack-src/src/avt/Plotter
1672 linked by target "avtplotter_par" in directory /tmp/axel/spack-stage/spack-stage-visit-develop-an2jjizo3id7bdttlm3p4ou3673zv4nh/spack-src/src/avt/Plotter
1673 linked by target "avtqtviswindow" in directory /tmp/axel/spack-stage/spack-stage-visit-develop-an2jjizo3id7bdttlm3p4ou3673zv4nh/spack-src/src/avt/QtVisWindow
1674 linked by target "viewersubjectproxy" in directory /tmp/axel/spack-stage/spack-stage-visit-develop-an2jjizo3id7bdttlm3p4ou3673zv4nh/spack-src/src/viewer/subjectproxy
There was a problem hiding this comment.
I tried hacking in a depends_on('glu') and this fixes this for me on Ubuntu 18.04 (by pulling in mesa-glu).
sethrj
left a comment
sethrj
left a comment
There was a problem hiding this comment.
The code changes look good, but the large blocks of comments are quite nonstandard. I think you can reorganize the visit dependency list to match the categories you set out, with one-line comments above each block of dependencies for the category. The installation note at the top should be moved to one or more github issues.
|
@sethrj not sure sure what the suggested prescription is for the dependency comments? Maybe you can clarify. Does spack have guidelines on comment styles? I am happy to add tickets related to the notes about building as well -- however I think its useful to have them in this file as well. If folks are interesting in building or improving the recipe, the context is right there. I actually wanted to have the building notes in the project description, but as @adamjstewart noted formatting undermines that strategy. |
|
@ax3l still gearing up to test the glu dep on one of our clusters, but I plan to get that in |
5 participants
No description provided.