Skip to content

PyTorch/Torchvision: fix deptype#16495

Merged
adamjstewart merged 1 commit intospack:developfrom
adamjstewart:packages/py-torch
May 6, 2020
Merged

PyTorch/Torchvision: fix deptype#16495
adamjstewart merged 1 commit intospack:developfrom
adamjstewart:packages/py-torch

Conversation

@adamjstewart
Copy link
Copy Markdown
Member

@adamjstewart adamjstewart commented May 6, 2020

The torchvision headers link to PyTorch headers, which link to pybind11 headers, so these should all be connected via link-type dependencies (unless we add include-types someday).

Without this, I see the following build failure:

In file included from /private/var/folders/21/hwq39zyj4g36x6zjfyl5l8080000gn/T/Adam/spack-stage/spack-stage-py-torchvision-0.6.0-regfy53rf4x4ucc6yj4iakpiuywleetv/spack-src/torchvision/csrc/vision.cpp:11:
In file included from /private/var/folders/21/hwq39zyj4g36x6zjfyl5l8080000gn/T/Adam/spack-stage/spack-stage-py-torchvision-0.6.0-regfy53rf4x4ucc6yj4iakpiuywleetv/spack-src/torchvision/csrc/DeformConv.h:3:
In file included from /private/var/folders/21/hwq39zyj4g36x6zjfyl5l8080000gn/T/Adam/spack-stage/spack-stage-py-torchvision-0.6.0-regfy53rf4x4ucc6yj4iakpiuywleetv/spack-src/torchvision/csrc/cpu/vision_cpu.h:2:
In file included from /Users/Adam/spack/opt/spack/darwin-catalina-x86_64/clang-11.0.3-apple/py-torch-1.5.0-ktctoccu4qvf6e4jkzstkw7d7ff56eyq/lib/python3.7/site-packages/torch/include/torch/extension.h:6:
In file included from /Users/Adam/spack/opt/spack/darwin-catalina-x86_64/clang-11.0.3-apple/py-torch-1.5.0-ktctoccu4qvf6e4jkzstkw7d7ff56eyq/lib/python3.7/site-packages/torch/include/torch/csrc/api/include/torch/python.h:12:
/Users/Adam/spack/opt/spack/darwin-catalina-x86_64/clang-11.0.3-apple/py-torch-1.5.0-ktctoccu4qvf6e4jkzstkw7d7ff56eyq/lib/python3.7/site-packages/torch/include/torch/csrc/utils/pybind.h:6:10: fatal error: 'pybind11/pybind11.h' file not found
#include <pybind11/pybind11.h>
         ^~~~~~~~~~~~~~~~~~~~~
1 error generated.

@adamjstewart adamjstewart merged commit 74b3ae4 into spack:develop May 6, 2020
@adamjstewart adamjstewart deleted the packages/py-torch branch May 6, 2020 23:05
aweits added a commit to aweits/spack that referenced this pull request May 12, 2020
@aweits
py-horovod: link dependency for py-torch
d4b5caa 
fix for same reasons as spack#16495.
@aweits aweits mentioned this pull request May 12, 2020
Merged
adamjstewart pushed a commit that referenced this pull request May 12, 2020
@aweits
py-horovod: link dependency for py-torch (#16600)
e36aa96 
fix for same reasons as #16495.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@adamjstewart