hdf: new version, variants and refactoring#16469
Merged
adamjstewart merged 4 commits intospack:developfrom May 26, 2020
Merged
Conversation
Member
Author
|
@adamjstewart @payerle could you take a look at this please and what do you think about making |
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Are you interested in maintaining this package? It looks like @lrknox is maintaining our HDF5 package, maybe they would be interested in HDF4 or know someone who would be a good maintainer.
Member
Author
|
I would leave the maintenance to someone else. I decided to refactor this just to be able to refactor |
adamjstewart
approved these changes
May 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.