bugfix: reorder variants in Spec strings#16462
Merged
Conversation
Member
Author
|
@adrienbernede can you confirm this fixes your reported issue? |
Member
|
Confirmed that the issue in #15362 is there on |
alalazo
approved these changes
May 12, 2020
Contributor
|
Sorry for missing that... |
becker33
added a commit
that referenced
this pull request
Jul 11, 2020
* change print order for variants to avoid zsh parsing bugs * change tests for new variant parse order
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
* change print order for variants to avoid zsh parsing bugs * change tests for new variant parse order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15362
Reorder variant strings so that
~foocan never be printed in a spec. This avoids bugs in zsh when users try to reuse Specs. See #15362 for details.