all_urls: add urls[0] for versions#16435
Merged
alalazo merged 1 commit intospack:developfrom May 8, 2020
Merged
Conversation
This adds the `url` alternative `urls` to `package.all_urls`. With this addition, one can find again new versions with `spack versions <package>` for packages that are populated with from mixin mirror `urls`. Example: `util-macros` from x.org mixin.
ax3l
commented
May 2, 2020
|
|
||
| # fetch from first entry in urls to save time | ||
| if hasattr(self, 'urls') and self.urls: | ||
| urls.append(self.urls[0]) |
Member
Author
There was a problem hiding this comment.
I wasn't sure if I should add all urls.
Pro:
- more robust
- works
- probably the right thing to do / least surprising
Con:
- can take a lot of extra time to find usually the exact same versions
- version exploration is not a super-critical operation yet if failing
alalazo
approved these changes
May 8, 2020
Member
|
Thanks @ax3l ! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
urlalternativeurlstopackage.all_urls. With this addition, one can find again new versions withspack versions <package>for packages that are populated with from mixin mirrorurls.Example:
util-macrosfrom x.org mixin.