QE-to-QMCPACK wave function converter relocation + some bug fixes#16422
Merged
junghans merged 10 commits intospack:developfrom May 3, 2020
Merged
QE-to-QMCPACK wave function converter relocation + some bug fixes#16422junghans merged 10 commits intospack:developfrom
junghans merged 10 commits intospack:developfrom
Conversation
added 7 commits
April 30, 2020 23:52
adamjstewart
reviewed
May 1, 2020
Co-authored-by: Adam J. Stewart <[email protected]>
Co-authored-by: Adam J. Stewart <[email protected]>
adamjstewart
approved these changes
May 2, 2020
…ust comments to reflect changes in code.
Contributor
Author
|
@adamjstewart I think travis-ci is borked up again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #16223
Also, fixed a bug with the hdf5 variant.
Will remove dependency patching in the qmcpack Spack package in a separate PR.