Skip to content

LLVM lldb 10.0: Python Link Dependency#16299

Merged
ax3l merged 2 commits intospack:developfrom
ax3l:fix-llvmLLDBpy
Apr 26, 2020
Merged

LLVM lldb 10.0: Python Link Dependency#16299
ax3l merged 2 commits intospack:developfrom
ax3l:fix-llvmLLDBpy

Conversation

@ax3l
Copy link
Copy Markdown
Member

@ax3l ax3l commented Apr 25, 2020 •
edited
Loading

A CMake option changed in LLVM 10 that controls the LLDB python bindings. This fixes a linker issue on Darwin with AppleClang, but was generally a missing dependency control.

cc @trws @naromero77 @adamjstewart

Refs.:

@ax3l ax3l requested a review from trws April 25, 2020 08:55
@ax3l ax3l changed the title LLVM: Python Dependency LLVM lldb: Python Dependency Apr 25, 2020
@ax3l ax3l changed the title LLVM lldb: Python Dependency LLVM lldb: Python Link Dependency Apr 25, 2020
@ax3l ax3l changed the title LLVM lldb: Python Link Dependency LLVM lldb 10.0: Python Link Dependency Apr 25, 2020
@ax3l
LLVM: Python Dependency
765f0fa 
Effort to expose the linked python library when building LLVM.
This might fix the forward propagation of libintl that comes
with the static python library build on darwin.
@ax3l
Copy link
Copy Markdown
Member Author

ax3l commented Apr 25, 2020 •
edited
Loading

GitHub action confirms this fixes the linker errors on macOS with AppleClang.

Unfortunately, there is more to be fixed to get py-jupyter built for this platform... but LLVM is good now :)

@naromero77
Copy link
Copy Markdown
Contributor

naromero77 commented Apr 25, 2020 via email

@ax3l
LLDB Py: Remove Ignored Old Flags
966a0c0 
Changed in LLVM 10.0+
@ax3l
Copy link
Copy Markdown
Member Author

ax3l commented Apr 25, 2020 •
edited
Loading

I just conditionally removed the old control var, since I saw it being ignored in LLVM 10.0+.

@naromero77 thanks, please feel free to cross check. I personally develop on Ubuntu 18.04 and have to run my macOS tests on Github Actions. Both look good :)

Here are a couple of further CMake flags that are ignored on the default built of our package with LLVM 10.0+ on macOS (probably all platforms). Likely the flags are still there, but have to be set in specific variants only (e.g. when +cuda is set). Anyway, a bit out of scope for this PR:

CMake Warning:
   Manually-specified variables were not used by the project:

CUDA_NVCC_EXECUTABLE
CUDA_SDK_ROOT_DIR
CUDA_TOOLKIT_ROOT_DIR
LIBOMPTARGET_DEP_CUDA_DRIVER_LIBRARIES
LINK_POLLY_INTO_TOOLS

@ax3l
Copy link
Copy Markdown
Member Author

ax3l commented Apr 25, 2020

@naromero77 @trws ready for merge :)

@naromero77
Copy link
Copy Markdown
Contributor

naromero77 commented Apr 26, 2020

I just conditionally removed the old control var, since I saw it being ignored in LLVM 10.0+.

@naromero77 thanks, please feel free to cross check. I personally develop on Ubuntu 18.04 and have to run my macOS tests on Github Actions. Both look good :)

Here are a couple of further CMake flags that are ignored on the default built of our package with LLVM 10.0+ on macOS (probably all platforms). Likely the flags are still there, but have to be set in specific variants only (e.g. when +cuda is set). Anyway, a bit out of scope for this PR:

CMake Warning:
   Manually-specified variables were not used by the project:

CUDA_NVCC_EXECUTABLE
CUDA_SDK_ROOT_DIR
CUDA_TOOLKIT_ROOT_DIR
LIBOMPTARGET_DEP_CUDA_DRIVER_LIBRARIES
LINK_POLLY_INTO_TOOLS

They are most likely coming from the else clause here:
https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/llvm/package.py#L274-L282

@trws Must have added them because he thought they were necessary, but I could double check next week.

@naromero77
Copy link
Copy Markdown
Contributor

naromero77 commented Apr 26, 2020

@naromero77 @trws ready for merge :)

I am OK with merging it in.

@ax3l ax3l merged commit 75042c3 into spack:develop Apr 26, 2020
@ax3l ax3l deleted the fix-llvmLLDBpy branch April 26, 2020 04:36
@scheibelp scheibelp mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

@trws trws Awaiting requested review from trws

Assignees

No one assigned

Labels

build-error macOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Installation issue: llvm on AppleClang

3 participants

@ax3l @naromero77 @adamjstewart