ucx : add version, modify variants#16252
Merged
adamjstewart merged 2 commits intospack:developfrom Apr 25, 2020
Merged
Conversation
adamjstewart
approved these changes
Apr 23, 2020
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
@hppritcha can you review this?
Contributor
|
@adamjstewart done added another thumbs up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pictoTrue(configure reports that static and shared libraries are built by default)java, set toFalsesinceucxwill automatically build java bindings if it findsjavaIs it okay to always enforce
+piclike this PR does or is it advisable to add variants forstaticandsharedand set those toTrueby default as well ?Closes #15987