update compiler config with bootstrapped compiler when already installed#16221
Merged
tldahlgren merged 4 commits intodevelopfrom Apr 22, 2020
Merged
update compiler config with bootstrapped compiler when already installed#16221tldahlgren merged 4 commits intodevelopfrom
tldahlgren merged 4 commits intodevelopfrom
Conversation
tldahlgren
requested changes
Apr 21, 2020
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Reviewed the code in context and see why this should've been added.
LGTM. It just needs a unit test.
becker33
force-pushed
the
bugfix/bootstrap-compiler-already-installed
branch
from
a0162c0 to
4d361c8
Compare
Member
Author
|
@tldahlgren test added and ready to go. |
tldahlgren
approved these changes
Apr 22, 2020
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
LGTM and new tests run for me.
Contributor
|
Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
config:install_missing_compilersis True,spack install foo %compiler_not_availableworks if the compiler is not installed, but fails if the compiler is already installed.This PR adds logic to update the compiler config upon finding that a needed compiler is already installed, in addition to doing so after installing it if it were not already installed.