Merged
Conversation
adamjstewart
approved these changes
Apr 20, 2020
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
@Sinan81 can you take a look?
Member
|
We could also set this in Qt's |
Member
|
I think this needs to be done in the |
added 2 commits
May 4, 2020 07:25
This reverts commit 00bd00e.
Member
Author
|
OK I moved the logic to |
Member
|
Flake8: |
Member
sethrj
approved these changes
May 6, 2020
Contributor
sethrj
left a comment
sethrj
left a comment
There was a problem hiding this comment.
Nice find. Looks good to me!
Member
|
I am afraid this PR broke builds for which in turn breaks the |
Member
Author
|
I think we need to revert it and rethink.
On Thu, May 7, 2020 at 03:37 Axel Huebl ***@***.***> wrote:
I am afraid this PR broke macOS builds for py-pyqt5:
2020-05-07T06:28:55.9981730Z ==> 1000: Installing py-pyqt5
2020-05-07T06:28:59.1368670Z ==> Warning: microarchitecture specific optimizations are not supported yet on mixed compiler toolchains [check ***@***.*** for further details]
2020-05-07T06:28:59.1445910Z ==> Error: AttributeError: 'Spec' object has no attribute 'stage'
2020-05-07T06:28:59.1446090Z
2020-05-07T06:28:59.1446220Z /Users/runner/runners/2.169.1/work/spack/spack/spack/var/spack/repos/builtin/packages/qt/package.py:227, in setup_dependent_build_environment:
2020-05-07T06:28:59.1446720Z 224 env.set('QTDIR', self.prefix)
2020-05-07T06:28:59.1447290Z 225 # https://riverbankcomputing.com/pipermail/qscintilla/2015-January/001012.html
2020-05-07T06:28:59.1447780Z 226 env.set('QMAKEFEATURES', join_path(
2020-05-07T06:28:59.1448260Z >> 227 dependent_spec.stage.source_path, 'Qt4Qt5', 'features'))
2020-05-07T06:28:59.1448340Z
2020-05-07T06:28:59.1448380Z
2020-05-07T06:28:59.3749430Z ==> Error: Failed to install py-pyqt5 due to ChildError: AttributeError: 'Spec' object has no attribute 'stage'
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16182 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOVY5Y6DOXJDNPXD243X5TRQJQLLANCNFSM4MMSGLEA>
.
--
Elizabeth Fischer, she/her
University of Alaska, Geophysical Institute
cell: 617-308-0436
UA is an AA/EO employer and educational institution and prohibits illegal
discrimination against any individual: www.alaska.edu/nondiscrimination.
|
Member
|
@citibeth sounds good to me, do you mind opening a PR please? |
Merged
Member
Author
|
See #16516 |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order for Qt packages to find their dependencies, the
QMAKEFEATUREenv var must be set appropriately at build time. This PR adds that necessary step.