Conversation
|
@hartzell did you have plans for aarch64 support? |
|
I'm kind of stuck right now, took a new job and it's getting in the way of me making contributions. Starting simply, this is fine. I think an easy but really useful improvement would be to control the choice of dependency provider by a variant, so that other platforms can use it easily. I think, but haven't been able to dig in, that that in the long term there should be some go-bootstrapper abstraction that can be satisfied by various providers (go-binaries, gcc, externals, etc...). |
|
Is there any other suggestion to refine this patch? |
|
Hi @adamjstewart @hartzell |
adamjstewart
left a comment
There was a problem hiding this comment.
I'm fine with the changes in this PR if @hartzell is
hartzell
left a comment
There was a problem hiding this comment.
Looks good. Sorry for mistaking the whitespace changes for new versions.
|
@darmac Do you have any documentation on how this worked for you? My ~1-year-old machine (darwin-bigsur-m1) uses the wrong condition in |
|
@sethrj I run spack (current develop branch) on a Taishan server (Kunpeng 920 CPU) give me : The fix from @darmac was working well for me, when I try to put it back I succeed to build go 1.18 |
No description provided.