Skip to content

New command flag: spack install --dependencies-only#1603

Merged
tgamblin merged 3 commits intospack:developfrom
citibeth:efischer/160823-InstallDependenciesOnly
Oct 5, 2016
Merged

New command flag: spack install --dependencies-only#1603
tgamblin merged 3 commits intospack:developfrom
citibeth:efischer/160823-InstallDependenciesOnly

Conversation

@citibeth
Copy link
Copy Markdown
Member

This allows Spack to install just a package's dependencies, without installing the package itself. Useful for non-standard packages, such as modele, which can't be installed with a simple spack install.

@tgamblin
Copy link
Copy Markdown
Member

@citibeth: this has test errors.

Elizabeth Fischer added 2 commits October 5, 2016 13:04
… UI remains the same.

2. install_self kwarg added to do_install().  Enables installation of a package's dependencies without installing the package itself.

3. Added `spack install --dependencies-only <package>` command.
@citibeth citibeth force-pushed the efischer/160823-InstallDependenciesOnly branch from 1b2828b to 246dec7 Compare October 5, 2016 17:10
@citibeth
Copy link
Copy Markdown
Member Author

citibeth commented Oct 5, 2016

I just rebased, should be ready to merge.

@tgamblin tgamblin merged commit abc9412 into spack:develop Oct 5, 2016
keep_stage=False,
ignore_deps=False,
install_deps=True,
install_self=True,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I am late at being picky here, but I find the API of do_install growing quite unintuitive. Now we may call a do_install that does no install at all, while the semantic needed for this PR could have been obtained directly in the install command traversing the DAG with or without root and calling an unmodified version of do_install from there.

@citibeth
Copy link
Copy Markdown
Member Author

citibeth commented Oct 5, 2016

I think this is worth a larger discussion on another Issues thread or the
mailing list.

On Wed, Oct 5, 2016 at 2:52 PM, Massimiliano Culpo <[email protected]

wrote:

@alalazo commented on this pull request.

In lib/spack/spack/package.py:

@@ -868,7 +868,8 @@ def _resource_stage(self, resource):
def do_install(self,
keep_prefix=False,
keep_stage=False,

  •               ignore_deps=False,
    
  •               install_deps=True,
    
  •               install_self=True,
    

Sorry if I am late at being picky here, but I find the API of do_install
growing quite unintuitive. Now we may call a do_install that does no
install at all, while the semantic needed for this PR could have been
obtained directly in the install command traversing the DAG with or
without root and calling an unmodified version of do_install from there.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1603 (review), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB1cd91HJip_6nVzg39YKjOxMmDpNXkpks5qw_H7gaJpZM4JrWsY
.

alalazo added a commit to epfl-scitas/spack that referenced this pull request Oct 7, 2016
alalazo added a commit to epfl-scitas/spack that referenced this pull request Oct 18, 2016
tgamblin pushed a commit that referenced this pull request Oct 18, 2016
* Removes the extra argument from Package.do_install while maintaining the changes in behavior pulled in #1603

* install : removed -i and -d shorthands (breaks backward compatibility)

* Change ':' to ','
paulhopkins pushed a commit to paulhopkins/spack that referenced this pull request Oct 24, 2016
)

* Removes the extra argument from Package.do_install while maintaining the changes in behavior pulled in spack#1603

* install : removed -i and -d shorthands (breaks backward compatibility)

* Change ':' to ','
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants