Update nano and fix coreutils on Darwin#15883
Update nano and fix coreutils on Darwin#15883adamjstewart merged 15 commits intospack:developfrom DiegoMagdaleno:develop
Conversation
|
I don't know why the test for the documentation failed, if I didn't modify any of those :/ |
This morning Sphinx released 3.0.0, which added a lot of fancy features like automatic type checking. Unfortunately/fortunately, these new features uncovered a bug in our Executable class. This has been fixed in develop, so if you rebase your PR on the tip of develop, it should pass the doc tests. |
| spec = self.spec | ||
| configure_args = [] | ||
| if spec.satisfies('platform=darwin'): | ||
| configure_args.append('--program-prefix=g') |
There was a problem hiding this comment.
I think I'm okay with this decision, but let's wait and hear from other users.
There was a problem hiding this comment.
Ok I'll bite. I use this without the prefix all the time. I think this should be an option, like +prefix. Homebrew ships coreutils with libexec/gnubin containing the non-prefixed binaries, so you can actually add it to your path.
Was there an issue with using this without the prefix? I've been using it that way on my mac for a while.
|
Unnecessary changes are removed :) |
| self.spec['libssh2'].prefix.lib | ||
| + '/libssh2.1.0.1.dylib'), | ||
| '{0}'.format( | ||
| prefix.lib + '/libgit2.1.0.0.dylib')) |
There was a problem hiding this comment.
Does this work?
@run_after('install')
def darwin_fix(self):
# The shared library is not installed correctly on Darwin; fix this
if self.spec.satisfies('platform=darwin'):
fix_darwin_install_name(self.prefix.lib) We have a builtin function to do this.
|
It seems like these changes are unrelated. It's best to open a separate PR for each package change, as it makes it easier to review. |
|
Oh yeah my bad, didn’t realise I committed this changes to the develop branch on my fork, I work on my own branch for that changes, will revert, my bad. |
|
Just reverted, sorry will work on my own branch from now on, forgot to do it, the only changes here are Nano and the coreutils, however, I will do a pull request for each package I fix or add, again sorry, and yeah I try the method you suggested in the code review for fixing libgit. |
3 participants
Coreutils:
Nano: