AutotoolsPackage: add aclocal for all build deps#15784
Merged
adamjstewart merged 1 commit intospack:developfrom Apr 17, 2020
Merged
AutotoolsPackage: add aclocal for all build deps#15784adamjstewart merged 1 commit intospack:developfrom
adamjstewart merged 1 commit intospack:developfrom
Conversation
Member
Author
|
Ping @scheibelp |
alalazo
approved these changes
Apr 8, 2020
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
Using only build dependencies seems the right thing to do 👍
Member
Author
|
Ping ping @scheibelp |
iomaganaris
added a commit
to BlueBrain/spack
that referenced
this pull request
Apr 30, 2020
iomaganaris
added a commit
to BlueBrain/spack
that referenced
this pull request
May 11, 2020
* Added gcc 9.3.0 to compilers.yaml * Fix issue with libconv in gcc * Fixed mpfr and mpc packages * Added autoconf-archive needed by mpfr * Search for all dependencies in autotools package for m4 header files - Similarly to spack#15784
ReinhardPrix
pushed a commit
to ReinhardPrix/spack
that referenced
this pull request
Jun 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the
autoreconfphase, we need to explicitly pass a list of directories in which to look for m4 headers. Previously, we only checked forpkgconfig, but there are many other packages that provide m4 headers. For example, among the software I currently have installed, I see the following packages with m4 headers:For a concrete example, while working on #15783, autoreconf failed unless autoconf-archive was added. I've also had problems with gettext being missing in the past.