Bugfix: remove unit tests that install real packages#15646
Merged
scheibelp merged 1 commit intospack:developfrom Mar 24, 2020
Merged
Bugfix: remove unit tests that install real packages#15646scheibelp merged 1 commit intospack:developfrom
scheibelp merged 1 commit intospack:developfrom
Conversation
…environment (spack#15577)" This reverts commit 25893f1.
Member
Author
|
For more info on how this can go wrong, see https://travis-ci.org/github/spack/spack/jobs/665754505?utm_medium=notification&utm_source=github_status (a build job for an innocent package PR #15627 submitted after 25893f1) |
This was referenced Mar 24, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our unit tests run many times. Any unit test which actually installs a package (which involves fetching code on the internet) is a severe bug because it runs an installation many times (i.e. re-downloading the same package for each version of Python that we run unit tests for).
This reverts commit 25893f1, which added tests that install real packages.