Merged
Conversation
Member
Author
|
Looks like we did not add a variant for the "backend" yet and only have an OpenMP variant so far. Would keep this for a follow-up where we remove "+openmp" and replace it with a multi-variant instead Other things to consider for follow-ups:
|
Update WarpX for recent developments: - add openPMD I/O (default: ON) - remove electro-static solver option (now a runtime option) - enable tiny profiler by default - depend on new CXX std support in make scripts for C++14 - WarpX only supports 2D and 3D in cartesian dims
f6493ab to
059535a
Compare
adamjstewart
approved these changes
Mar 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update WarpX from for recent developments:
CC for review: @dpgrote @MaxThevenet @RemiLehe