spack.relocate: add unit test#15610
Merged
alalazo merged 5 commits intospack:developfrom Mar 24, 2020
Merged
Conversation
This aims at consistency in naming with both the standard library (ValueError, AttributeError, etc.) and other errors in 'spack.error'. Improved existing docstrings
The search function that searches for patchelf has been refactored to remove deply nested conditionals. Extended docstring.
alalazo
force-pushed
the
maintainers/relocate_unit_tests
branch
from
ded9e53 to
718e127
Compare
Member
Author
|
@gartung Can you have a look at this PR? I'll probably work on adding more unit tests like this one once this is reviewed and merged (rather than adding more code here, which I guess will make the PR more difficult to review). |
gartung
approved these changes
Mar 21, 2020
Member
Author
|
Thanks @gartung ! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a minor refactoring of a couple of functions in
spack.relocateto be more in line with current practices in other parts Spack (see single commit descriptions for details). It also adds a unit test for the function searching forpatchelf.