Skip to content

davix: add cxxstd variant#15593

Merged
gartung merged 2 commits intospack:developfrom
drbenmorgan:davix-cxxstd
Mar 21, 2020
Merged

davix: add cxxstd variant#15593
gartung merged 2 commits intospack:developfrom
drbenmorgan:davix-cxxstd

Conversation

@drbenmorgan
Copy link
Copy Markdown
Member

@drbenmorgan drbenmorgan commented Mar 20, 2020

Davix is written in C++, so add a cxxstd variant to allow dependents to specify this so a consistent ABI is used. Its only dependents is the root package, so that may need updating in due course.

@drbenmorgan
davix: add cxxstd variant
7a22106 
Davix is written in C++, so add this variant to allow dependents to specify
this so a consistent ABI is used.
@adamjstewart
Copy link
Copy Markdown
Member

adamjstewart commented Mar 20, 2020

Flake8:

var/spack/repos/builtin/packages/davix/package.py:23: [E128] continuation line under-indented for visual indent
var/spack/repos/builtin/packages/davix/package.py:24: [E128] continuation line under-indented for visual indent
var/spack/repos/builtin/packages/davix/package.py:25: [E128] continuation line under-indented for visual indent
var/spack/repos/builtin/packages/davix/package.py:26: [E128] continuation line under-indented for visual indent
var/spack/repos/builtin/packages/davix/package.py:37: [W391] blank line at end of file

@gartung gartung merged commit bb4e9a7 into spack:develop Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gartung gartung gartung approved these changes

@adamjstewart adamjstewart adamjstewart approved these changes

@greenc-FNAL greenc-FNAL Awaiting requested review from greenc-FNAL

Assignees

No one assigned

Labels

new-variant

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drbenmorgan @adamjstewart @gartung