Skip to content

revbayes: Update pre-build process#15485

Merged
adamjstewart merged 1 commit intospack:developfrom
njbooher:revbayes-generategitversion
Mar 18, 2020
Merged

revbayes: Update pre-build process#15485
adamjstewart merged 1 commit intospack:developfrom
njbooher:revbayes-generategitversion

Conversation

@njbooher
Copy link
Copy Markdown
Contributor

@njbooher njbooher commented Mar 13, 2020

The development branch requires running a new script before compiling.

@adamjstewart
Copy link
Copy Markdown
Member

adamjstewart commented Mar 13, 2020

Is it only needed for the develop branch or will it also be needed in future tarball releases?

@njbooher
Copy link
Copy Markdown
Contributor Author

njbooher commented Mar 13, 2020 •
edited
Loading

Another release is planned for sometime next week and there's no sign of anybody wanting to change it, so I would imagine it will be needed for future releases.

The actual future proof way to handle this would be to have the package run this instead for building since it's the thing that seems to maintain an interface:

https://github.com/revbayes/revbayes/blob/development/projects/cmake/build.sh

But if we switched to that would we still want this to derive from CMakePackage since that script runs cmake and make for you?

@adamjstewart adamjstewart merged commit 156b59c into spack:develop Mar 18, 2020
@njbooher njbooher deleted the revbayes-generategitversion branch March 18, 2020 18:23
@njbooher njbooher mentioned this pull request May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees

No one assigned

Labels

update-package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@njbooher @adamjstewart