trilinos: setting old GO default values for older trilinos versions#15439
Merged
adamjstewart merged 1 commit intospack:developfrom Sep 22, 2020
Merged
Conversation
Contributor
|
Any hopes of getting this PR merged? I verified this fixes my issue #15423 |
Member
|
@davydden @jppelteret @keitat @luca-heltai can you review this PR? @mathsen can you rebase this to resolve the merge conflicts? |
mathsen
force-pushed
the
trilinos_ancient_global_ordinal
branch
2 times, most recently
from
a9d9ddb to
0c25b1e
Compare
…lly) not break the installation. Adjusting dealii package to just explicitly set GO if trilinos >= 12.18.1 is installed
mathsen
force-pushed
the
trilinos_ancient_global_ordinal
branch
from
0c25b1e to
40bc953
Compare
adamjstewart
approved these changes
Sep 1, 2020
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Still waiting for maintainers to review. If no one reviews in a week, ping me and I'll merge.
luca-heltai
approved these changes
Sep 4, 2020
Contributor
|
Sorry. I was AFK. |
jppelteret
approved these changes
Sep 22, 2020
Contributor
jppelteret
left a comment
jppelteret
left a comment
There was a problem hiding this comment.
LGTM! Apologies as well, I've not been keeping an eye on my Github notifications for some time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... in order to not break the installation of older versions.
I hope this fixes issue 15423
Also adjusting dealii package to just explicitly set GO if trilinos >= 12.18.1 is installed and use the old default otherwise.
Maybe this is a good chance to also merge pull request 14215