Add Axom spack package#15432
Merged
becker33 merged 24 commits intospack:developfrom May 5, 2020
white238:feature/white238/addaxom
Merged
Add Axom spack package#15432becker33 merged 24 commits intospack:developfrom white238:feature/white238/addaxom
becker33 merged 24 commits intospack:developfrom
white238:feature/white238/addaxom
Conversation
Contributor
Author
|
This passes all internal Axom tests. |
Contributor
Author
|
Added missing shroud package that was already in Axom. |
Member
|
conduit changes LGTM (Look good to me or Look galant to minotaur, either way good!). |
adamjstewart
requested changes
Mar 18, 2020
Contributor
Author
|
I realize py-shroud disappeared for some reason during my rebase. I'll fix it after confirming the last set of changes still work for our project. |
Contributor
Author
|
This passes all of Axom's internal testing and is good to be merged. Thanks for the help @becker33 and @adamjstewart ! |
Member
|
awesome work @white238 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an Axom spack package that runs on all the Axom supported LLNL systems. I have run flake8 on all the files.
I am currently re-running our battery of tests which should pass because these files should have no changes other than style in them from what was already in Axom. This takes a couple hours.