Cray bugfix: TERM missing while reading default target#15381
Merged
Cray bugfix: TERM missing while reading default target#15381
Conversation
tgamblin
requested changes
Mar 8, 2020
lib/spack/spack/platforms/cray.py
Outdated
| env = which('env') | ||
| output = env("-i", "/bin/bash", "-lc", "echo $CRAY_CPU_TARGET", | ||
| output = env("-i", "TERM=%s" % os.environ['TERM'], | ||
| "/bin/bash", "-lc", "echo $CRAY_CPU_TARGET", |
Member
There was a problem hiding this comment.
Can we do this in a slightly less complex way without relying on env?
bash = Executable("/bin/bash")
bash("-lc", "echo", "$CRAY_CPU_TARGET",
env={"TERM": os.environ["TERM"]})
lib/spack/spack/platforms/cray.py
Outdated
| if _target is None and name == 'back_end': | ||
| _target = self._default_target_from_env() | ||
| if _target is not None: | ||
| if _target: |
Member
There was a problem hiding this comment.
What real case is this change handling?
Member
Author
There was a problem hiding this comment.
_default_target_from_env can return whitespace.
Member
There was a problem hiding this comment.
I think we should fix that in _default_target_from_env instead of here.
Member
Author
There was a problem hiding this comment.
I think this is clearer and more pythonic. I went back and forth on this.
_default_target_from_env runs a bash command and parses the output. If it gets anything, that's the target, if not, additional logic.
Member
There was a problem hiding this comment.
I do not think _default_target_from_env should return whitespace for failure -- can it really return whitespace or None?
Member
Author
There was a problem hiding this comment.
It can't return None currently. It has to return a string.
Member
Author
There was a problem hiding this comment.
Reworked so it returns None, but I don't think this is an improvement.
tgamblin
approved these changes
Mar 19, 2020
tgamblin
pushed a commit
that referenced
this pull request
Mar 20, 2020
Bug: Spack hangs on some Cray machines Reason: The TERM environment variable is necessary to run bash -lc "echo $CRAY_CPU_TARGET", but we run that command within env -i, which wipes the environment. Fix: Manually forward the TERM environment variable to env -i /bin/bash -lc "echo $CRAY_CPU_TARGET"
3 tasks
1 task
likask
pushed a commit
to likask/spack
that referenced
this pull request
Apr 7, 2020
…upstream_master * commit 'e2b1737a42c9c0c796671f9dd0c39f623e4c91c0': (1343 commits) update CHANGELOG.md for 0.14.1 version bump: 0.14.1 multiprocessing: allow Spack to run uninterrupted in background (spack#14682) Cray bugfix: TERM missing while reading default target (spack#15381) Upstreams: don't write metadata directory to upstream DB (spack#15526) Creating versions from urls doesn't modify class attributes (spack#15452) bugfix: fix install_missing_compilers option bug from v0.14.0 (spack#15416) bugfix: installer.py shouldn't be executable (spack#15386) Add function replace_prefix_nullterm for use on mach-o rpaths. (spack#15347) ArchSpec: fix semantics of satisfies when not concrete and strict is true (spack#15319) suite-sparse: fix installation for v5.X (spack#15326) testing: increase installer coverage (spack#15237) bugfix: resolve undefined source_pkg_dir failure (spack#15339) Bugfix: resolve StopIteration message attribute failure (spack#15341) Recover coverage from subprocesses during unit tests (spack#15354) Correct pytest.raises matches to match (spack#15346) bugfix: Add dependents when initializing spec from yaml (spack#15220) Uniquify suffixes added to module names (spack#14920) bugfix: ensure proper dependency handling for package-only installs (spack#15197) Fix for being able to 'spack load' packages that have been renamed. (spack#14348) ... # Conflicts: # .travis.yml # lib/spack/spack/modules/common.py # var/spack/repos/builtin/packages/mofem-cephas/package.py # var/spack/repos/builtin/packages/mofem-fracture-module/package.py # var/spack/repos/builtin/packages/mofem-users-modules/package.py # var/spack/repos/builtin/packages/python/package.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Spack hangs on some Cray machines
Reason: The
TERMenvironment variable is necessary to runbash -lc "echo $CRAY_CPU_TARGET", but we run that command withinenv -i, which wipes the environment.Fix: Manually forward the
TERMenvironment variable toenv -i /bin/bash -lc "echo $CRAY_CPU_TARGET"