Closed
Conversation
This comment has been minimized.
This comment has been minimized.
3 tasks
Member
Author
|
Ping @scheibelp, we need to decide on whether or not we want this. |
Member
I have added a response to the discussion in #9034 (comment), IMO those concerns should be resolved before we proceed with this |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a necessary dependency for the
jinja2andpytestpackages we already vendor. It also allows us to do fancy things in thePythonPackagebase class, like automatically detect which libraries to try to import (coming in a follow-up PR).Setuptools includes a few vendored dependencies of its own (
appdirs,packaging,pyparsing,six). We could remove these, or move them tolib/spack/external, but that would require hacking the setuptools code to import them normally.Closes #9034
Follow-up of #9261