Skip to content

New package: ripgrep#15343

Merged
ax3l merged 1 commit intospack:developfrom
hartzell:new-package-ripgrep
Mar 5, 2020
Merged

New package: ripgrep#15343
ax3l merged 1 commit intospack:developfrom
hartzell:new-package-ripgrep

Conversation

@hartzell
Copy link
Copy Markdown
Contributor

@hartzell hartzell commented Mar 4, 2020

Add package for ripgrep:

ripgrep is a line-oriented search tool that recursively searches
your current directory for a regex pattern.  ripgrep is similar to
other popular search tools like The Silver Searcher, ack and grep.

Add package for ripgrep:

    ripgrep is a line-oriented search tool that recursively searches
    your current directory for a regex pattern.  ripgrep is similar to
    other popular search tools like The Silver Searcher, ack and grep.

homepage = "https://github.com/BurntSushi/ripgrep"
url = "https://github.com/BurntSushi/ripgrep/archive/11.0.2.tar.gz"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, do you want to list yourself as package maintainer, @hartzell ?

Suggested change
maintainers = ['hartzell']

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not unless you insist, I'm between gigs at the moment and am not sure how OSS work I'll be able to do depending on where I land. AKA, commitment issues....

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I threw all three of these things in because a) I use them and b) I'm playing with the support for "stacking" spack installations and needed some things that were built with rust so that I can ensure that Lmod's compiler based hierarchies don't get confused (e.g. at one point D things like sambamba ended up in separate parts of the hierarchy because D->LLVM and therefore couldn't be loaded alongside things built with gcc)

from spack import *


class Ripgrep(Package):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, we don't have a RustPackage or CargoPackage yet?
Do you want to define one? :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about how it all works to deal with it yet; it suffers from the "competing package manager & how do we handle dependencies that cargo wants to handle" issue and I don't know what the solution would look like.

I still have finishing up support for Go (#14061) on the list (I'd love input from more than me and @scheibelp about whether the spack community trusts the Go module systems signatures or wants to Do It Ourselves).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no prob, maybe @trws and @sknigh have an idea on this as they committed rust-related works to Spack before.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d leave it for now, we have other rust packages that are built just like this. There’s also a bit of a policy decision we need to think about when making a first-class cargo package class. At the moment this, and others like it, fetch most of their actual deps with cargo and spack is completely unaware of them. Either way, I wouldn’t hold this one up on it.

@ax3l ax3l added the rust label Mar 4, 2020
@ax3l
Copy link
Copy Markdown
Member

ax3l commented Mar 4, 2020

Both review questions also apply for #15344 and #15345 :)

@hartzell
Copy link
Copy Markdown
Contributor Author

hartzell commented Mar 5, 2020

@ax3l -- same answer 😧....

@ax3l ax3l requested a review from trws March 5, 2020 01:31
@ax3l ax3l merged commit 3a8800b into spack:develop Mar 5, 2020
@hartzell hartzell mentioned this pull request Mar 6, 2020
@hartzell hartzell deleted the new-package-ripgrep branch March 6, 2020 18:27
@ax3l ax3l mentioned this pull request Jun 27, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants