Conversation
Since 1.9.0 is broken for Darwin, which impacts many developers, and the fix is still a RC, let's keep the previous release as default. This avoids distruption for OSX developers and CI.
sethrj
left a comment
sethrj
left a comment
There was a problem hiding this comment.
I'm personally fine with this but will defer to @adamjstewart who recommended the default be switched to "last released version" from the release candidate that I'd selected in my previous MR. In the meantime, the conflict marker from that MR will at least turn this into a concretization-time error rather than the build-time error which @LDAmorim and I encountered, and it's easy enough to build your toolchain with ^[email protected] or by adding a preferred version to your packages.yaml file.
|
I just verified that 1.8.1 builds on my mac without intervention: |
|
FYI, this PR reverted the libfabric version for all platforms, not just OSX. Possibly a moot point now because 1.9.1 was just released. Can someone check if that one works on OSX and add that version in as the preferred if so? |
|
I think that was the author's intent: "most recent version that works with all platforms". I'm checking out the install on my mac now. EDIT: yes this works |
|
Thanks @sethrj ! Just for general policy feedback, I would suggest caution when reverting versions cross-platform for a package that's already been on a given version for a while, particularly for packages that tend to evolve significantly across versions. In this specific example, libfabric 1.8.1 does indeed compile and run everywhere as far as I know, but it was a step backwards on stability and performance for some network providers. |
|
Also agree with @carns, would be good in that case if spack had an option to say preferred="osx", instead of preferred="True"... |
|
I prefer something that already worked over a default-broken user experience on a major OS. Especially since it was obviously that this is a temporary fix to something that was the working default for months.
Please open a PR with 1.9.1 as it's ready now and ping the reporters with Mac issues on it :)
|
|
P.S.: has libfabric no CI for macOS?
|
|
looks like the PR for 1.9.1 was already opened. Yes it has: https://travis-ci.org/ofiwg/libfabric |
5 participants
Since 1.9.0 is broken for Darwin, which impacts many developers, and the fix is still a RC, let's keep the previous release as default.
This avoids disruption for OSX developers and CI.
(I think things should install with defaults on major platforms and should not require variant or dependency tweaks.)
Follow-up to #15254 #15244