Skip to content

Fix ArchSpec.satisfies when not concrete and strict is true#15319

Merged
alalazo merged 1 commit intospack:developfrom
alalazo:fixes/archspec_concretization_error
Mar 7, 2020
Merged

Fix ArchSpec.satisfies when not concrete and strict is true#15319
alalazo merged 1 commit intospack:developfrom
alalazo:fixes/archspec_concretization_error

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Mar 4, 2020

fixes #15306
fixes #14754

@eugeneswalker
Copy link
Copy Markdown
Contributor

Should resolve #14754

Copy link
Copy Markdown
Contributor

@eugeneswalker eugeneswalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Mar 7, 2020

@tgamblin @scheibelp Merging this 2 lines fix + tests

@alalazo alalazo merged commit b444fd2 into spack:develop Mar 7, 2020
@alalazo alalazo deleted the fixes/archspec_concretization_error branch March 7, 2020 12:58
likask pushed a commit to likask/spack that referenced this pull request Apr 7, 2020
…upstream_master

* commit 'e2b1737a42c9c0c796671f9dd0c39f623e4c91c0': (1343 commits)
  update CHANGELOG.md for 0.14.1
  version bump: 0.14.1
  multiprocessing: allow Spack to run uninterrupted in background (spack#14682)
  Cray bugfix: TERM missing while reading default target (spack#15381)
  Upstreams: don't write metadata directory to upstream DB (spack#15526)
  Creating versions from urls doesn't modify class attributes (spack#15452)
  bugfix: fix install_missing_compilers option bug from v0.14.0 (spack#15416)
  bugfix: installer.py shouldn't be executable (spack#15386)
  Add function replace_prefix_nullterm for use on mach-o rpaths. (spack#15347)
  ArchSpec: fix semantics of satisfies when not concrete and strict is true (spack#15319)
  suite-sparse: fix installation for v5.X (spack#15326)
  testing:  increase installer coverage (spack#15237)
  bugfix: resolve undefined source_pkg_dir failure (spack#15339)
  Bugfix: resolve StopIteration message attribute failure (spack#15341)
  Recover coverage from subprocesses during unit tests (spack#15354)
  Correct pytest.raises matches to match (spack#15346)
  bugfix:  Add dependents when initializing spec from yaml (spack#15220)
  Uniquify suffixes added to module names (spack#14920)
  bugfix: ensure proper dependency handling for package-only installs (spack#15197)
  Fix for being able to 'spack load' packages that have been renamed. (spack#14348)
  ...

# Conflicts:
#	.travis.yml
#	lib/spack/spack/modules/common.py
#	var/spack/repos/builtin/packages/mofem-cephas/package.py
#	var/spack/repos/builtin/packages/mofem-fracture-module/package.py
#	var/spack/repos/builtin/packages/mofem-users-modules/package.py
#	var/spack/repos/builtin/packages/python/package.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something wasn't working, here's a fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hpctoolkit os=ubuntu18.04 : 'NoneType' object has no attribute 'microarchitecture' Error concretizing environment containing only hpctoolkit

3 participants