package: Add fetch_options variable#15317
Conversation
PR spack#15212 added a new connect_timeout option that can be overriden using fetch_options but had to specified per-version. This adds a new per-package variable that can be used to override fetch_options.
|
Do you think there may be cases where the URL changes and we only want to apply a timeout for a subset of versions? I think this removes the ability to specify timeouts on a per-version basis as added in #15212. Overall I think this is more useful than that, but I think there may be cases were people would prefer the feature added in #15212. If you think that is unlikely, we can just merge this without changes, since for its intended purpose it looks good to me. |
Per-version timeouts should still work, see for instance the resources in the gcc and verrou packages. The precedence should be: global connect_timeout, per-package fetch_options, per-version/resource fetch_options. |
This makes sure that a package's fetch_options are used when fetching new versions to checksum. This allows working around problems with slow servers or those requiring a cookie to be set. Depends on spack#15317
This makes sure that a package's fetch_options are used when fetching new versions to checksum. This allows working around problems with slow servers or those requiring a cookie to be set. Depends on spack#15317
|
Closing/reopening to restart tests |
|
Thanks for all your work on this! |
This makes sure that a package's fetch_options are used when fetching new versions to checksum. This allows working around problems with slow servers or those requiring a cookie to be set. Depends on spack#15317
|
@michaelkuhn this is a nice feature, thank you. What do you think it would take to honour |
3 participants
PR #15212 added a new connect_timeout option that can be overriden using fetch_options but had to specified per-version. This adds a new per-package variable that can be used to override fetch_options.