Pad binary test replacement with os.sep instead of b\0#15311
Closed
Pad binary test replacement with os.sep instead of b\0#15311
Conversation
Member
Author
|
Padding with anything other than b'\0' results is a size change. |
This was referenced Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When replacing text in binary files the difference in the old path and the new path is padded with nulls. This leads to extraneous nulls in perl @inc path as shown in the attached log. The suggested solution of padding with '/' or os.sep did not work. Padding with spaces might work.
spack-build-out.txt