Remove DB conversion from index.yaml#15298
Merged
scheibelp merged 4 commits intospack:developfrom Mar 5, 2020
Merged
Conversation
fixes spack#13122 Removed the code that was converting the old index.yaml format into index.json. Since the change happened in spack#2189 it should be considered safe to drop this (untested) code.
Removed the possibility to call this function with an open stream of a filename since it's private to the module and is never called with a stream directly.
This highlights the cases in which we don't want to take a lock / need to raise an error. As a result conditionals are nested by one level less. Also reorder imports to be in alphabetic order.
scheibelp
requested changes
Mar 4, 2020
Member
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
I have one request (there is a redundant check). Once that is addressed, then this will be good.
Member
Author
|
@scheibelp Ready for another review! Thanks! |
scheibelp
approved these changes
Mar 5, 2020
Member
|
Thanks! |
tgamblin
pushed a commit
that referenced
this pull request
Apr 15, 2020
Removed the code that was converting the old index.yaml format into index.json. Since the change happened in #2189 it should be considered safe to drop this (untested) code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13122
Removed the code that was converting the old
index.yamlformat intoindex.json. Since the change happened in #2189 it should be considered safe to drop this (untested) code.