Fix compiling dealii with trilinos@master#15288
Merged
adamjstewart merged 1 commit intospack:developfrom Mar 3, 2020
Merged
Conversation
…ng dealii to GO int, to make it compile again
davydden
reviewed
Mar 2, 2020
| depends_on('slepc@:3.6.3', when='@:8.4.1+slepc+petsc+mpi') | ||
| depends_on('slepc~arpack', when='+slepc+petsc+mpi+int64') | ||
| depends_on('sundials@:3~pthread', when='@9.0:+sundials') | ||
| depends_on('trilinos gotype=int', when='+trilinos') |
Member
There was a problem hiding this comment.
i don't think Spack can combine depends_on, you should probably add this to each depends_on below
Member
There was a problem hiding this comment.
Spack merges all depends_on constraints, so this should be fine
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-picking global ordinal type variant selector from this pull request and setting dealii to GO int, to make it compile again