Hack to select iconv implementation - libiconv vs. libc iconv. #15213
Closed
iarspider wants to merge 8 commits intospack:developfrom
Closed
Hack to select iconv implementation - libiconv vs. libc iconv. #15213iarspider wants to merge 8 commits intospack:developfrom
iarspider wants to merge 8 commits intospack:developfrom
Conversation
iarspider
changed the title
Contributor
Author
|
Not sure about one small detail: do we want only |
iarspider
added a commit
to iarspider/spack
that referenced
this pull request
Mar 11, 2020
(re-do of spack#15213 due to changes in gnupg recipe)
27 tasks
adamjstewart
pushed a commit
that referenced
this pull request
Mar 28, 2020
(re-do of #15213 due to changes in gnupg recipe)
ReinhardPrix
pushed a commit
to ReinhardPrix/spack
that referenced
this pull request
Jul 20, 2020
…15437) (re-do of spack#15213 due to changes in gnupg recipe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We at SFT-SPI would like to use libc's implementation of iconv, as opposed to libiconv one. This PR introduces a new virtual package
iconvand a dummy packagelibcto provide it.lib's and libiconv's implementation of iconv should be compatible on API level, but I'm testing this just in case.
Packages that directly depend on libiconv: