config: Add a new option download_timeout#15212
Merged
scheibelp merged 3 commits intospack:developfrom Feb 27, 2020
Merged
Conversation
scheibelp
reviewed
Feb 25, 2020
connect_timeout can be used to increase the time Spack waits for the server to answer. This can be used to work around slow connections or servers. Fixes spack#14700
This allows us to support higher-level concepts such as 'cookie' and 'timeout' without users having to specify curl options.
This allows packages to override the global connect_timeout.
michaelkuhn
force-pushed
the
config-timeout
branch
from
088e43f to
baf6c29
Compare
alalazo
approved these changes
Feb 26, 2020
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
It would be good in a following PR to avoid having to pass fetch_options to every version in a package.
Contributor
|
I think this PR would resolve my issue with timeouts |
Member
|
This is great - thanks! |
michaelkuhn
added a commit
to michaelkuhn/spack
that referenced
this pull request
Mar 4, 2020
PR spack#15212 added a new connect_timeout option that can be overriden using fetch_options but had to specified per-version. This adds a new per-package variable that can be used to override fetch_options.
scheibelp
pushed a commit
that referenced
this pull request
Mar 13, 2020
PR #15212 added a new connect_timeout option that can be overridden using fetch_options but had to specified per-version. This adds a new per-package variable that can be used to override fetch_options for all versions in the package. This includes connect_timeout as well as 'cookie' (e.g. for the jdk package). Packages can combine package-level fetch_options with per-version fetch_options, in which case the version fetch_options completely override the package-level fetch_options. This commit includes tests for the added behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
download_timeout can be used to increase the time Spack waits for the server to answer. This can be used to work around slow servers.
Fixes #14700