Skip to content

Remove 'spack bootstrap' and associated docs#15179

Merged
becker33 merged 1 commit intospack:developfrom
alalazo:qa/remove_bootstrap_command
May 11, 2020
Merged

Remove 'spack bootstrap' and associated docs#15179
becker33 merged 1 commit intospack:developfrom
alalazo:qa/remove_bootstrap_command

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Feb 24, 2020

fixes #15145

This commit removes the outdated spack bootstrapcommand and any reference to it in the documentation and unit tests.

Once ``curl`` has been installed, you can similarly install the others.


.. _InstallEnvironmentModules:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is still relevant to using the module files that we generate, even if they're not necessary for spack load to work anymore.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it belongs here. This section seems to be specifically focused on software you need to have for Spack to be fully functional. Anyhow, reviewing docs I found this part that I didn't catch looking for mentions of spack bootstrap. This also needs to be revised, so maybe some brief information on how you could install a module system can be added there? In case would you prefer to have the modifications done in this PR or a later one?

@alalazo alalazo requested a review from scheibelp March 5, 2020 12:28
@alalazo alalazo requested review from becker33 and tgamblin March 24, 2020 13:58
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Apr 17, 2020

ping

@alalazo alalazo force-pushed the qa/remove_bootstrap_command branch from 8c3f40c to 91bfff6 Compare April 27, 2020 16:13
@becker33
Copy link
Copy Markdown
Member

becker33 commented May 8, 2020

@alalazo sorry this fell off my plate, I think we should merge this in the near future. Can you fix the conflict in the bash completion?

fixes spack#15145

This commit removes the outdated `spack bootstrap`
command and any reference to it in the documentation
and unit tests.
@alalazo alalazo force-pushed the qa/remove_bootstrap_command branch from 91bfff6 to 76febd0 Compare May 9, 2020 10:56
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented May 9, 2020

@becker33 Done!

@becker33 becker33 merged commit 43c9ad3 into spack:develop May 11, 2020
@alalazo alalazo deleted the qa/remove_bootstrap_command branch May 11, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove 'spack bootstrap' from the commands

3 participants