packages.yaml: allow virtuals to specify buildable: false#14934
Merged
packages.yaml: allow virtuals to specify buildable: false#14934
Conversation
becker33
force-pushed
the
features/allow-virtual-buildable-false
branch
from
8c65137 to
4f653c1
Compare
tgamblin
approved these changes
Mar 26, 2020
Member
|
@becker33: this needs docs in a follow-on PR |
Member
|
Tried to test drive this and it seems to work correctly. One comment I have before diving into the implementation is that the error message when trying to enforce another provider: $ spack spec netlib-scalapack ^openmpi
Input spec
--------------------------------
netlib-scalapack
^openmpi
Concretized
--------------------------------
==> Error: The spec
'openmpi ^autoconf ^automake ^gdbm ^hwloc@:1.999 ^libtool ^[email protected]: ^ncurses ^numactl ^perl ^pkgconfig ^readline'
is configured as not buildable, and no matching external installs were foundcan probably be improved. For instance: $ spack spec netlib-scalapack ^openmpi
Input spec
--------------------------------
netlib-scalapack
^openmpi
Concretized
--------------------------------
==> Error: "mpi" is not buildable and no externals matching "openmpi" were found. Run "spack config get packages" for more details. |
alalazo
previously requested changes
Mar 26, 2020
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
This LGTM overall, only left minor suggestions to improve implementation details.
7 tasks
Member
becker33
force-pushed
the
features/allow-virtual-buildable-false
branch
from
3ca644d to
7e38fda
Compare
Co-Authored-By: Massimiliano Culpo <[email protected]>
tgamblin
approved these changes
Mar 31, 2020
Member
|
@adamjstewart: this is approved -- want to update the config tutorial? |
jedbrown
added a commit
that referenced
this pull request
Mar 31, 2020
* origin/develop: packages.yaml: allow virtuals to specify buildable: false (#14934) GMT: add 6.0.0 (#15785) autoconf-archive: add new package (#15782) JasPer: add 2.0.16 (#15781) Update link for codecov's browser extensions (#15779) geant4: new version 10.6 plus simplifications (#15447) ppOpen-APPL/FVM: new package. (#15772)
2 tasks
ax3l
added a commit
to spack/spack-tutorial
that referenced
this pull request
Jul 22, 2020
Document virtual package configs as documented in spack/spack#14934 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, to force Spack to use an external MPI, you have to specify
buildable: Falsefor every MPI provider in Spack in your packages.yaml file. This is both tedious and fragile, as new MPI providers can be added and break your workflow when you do a git pull.This PR allows you to specify an entire virtual dependency as non-buildable, and specify particular implementations to be built:
will force all Spack builds to use the specified mpich install.