Set 'fflags' as FCFLAGS when the flags must be passed to Autotools.#14788
Merged
scheibelp merged 1 commit intospack:developfrom Mar 3, 2020
Merged
Set 'fflags' as FCFLAGS when the flags must be passed to Autotools.#14788scheibelp merged 1 commit intospack:developfrom
scheibelp merged 1 commit intospack:developfrom
Conversation
… build system arguments.
Member
|
Closing/reopening to restart tests |
scheibelp
approved these changes
Feb 28, 2020
Member
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
LGTM! I may not get a chance to merge this until 3/3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spack's
fflagsare meant for bothf77andfc. Therefore, they must to be passed asFFLAGSandFCFLAGSto the configure scripts of Autotools-based packages.