bugfix: gpg2 is called 'gpg' on macOS#14594
Merged
Conversation
alalazo
previously requested changes
Jan 22, 2020
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
See comment below for the failure in Travis
2 tasks
tgamblin
force-pushed
the
bugfix/no-gpg2-on-osx
branch
3 times, most recently
from
4f12919 to
b754c26
Compare
Member
Author
|
@alalazo: I had to tweak one more thing to get this working on macOS -- GPG can only handle |
The gpg2 command isn't always around; it's sometimes called gpg. This is the case with the brew-installed version, and it's breaking our tests. - [x] Look for both 'gpg2' and 'gpg' when finding the command - [x] If we find 'gpg', ensure the version is 2 or higher - [x] Add tests for version detection.
tgamblin
force-pushed
the
bugfix/no-gpg2-on-osx
branch
from
b754c26 to
6cf76e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gpg2command isn't always around; it's sometimes calledgpg. This is the case with the brew-installed version, and it's breaking our tests.This fixes the currently breaking macOS tests.