Updates to casacore package#14552
Merged
adamjstewart merged 6 commits intospack:developfrom Jan 18, 2020
mpokorny:casacore
Merged
Updates to casacore package#14552adamjstewart merged 6 commits intospack:developfrom mpokorny:casacore
adamjstewart merged 6 commits intospack:developfrom
mpokorny:casacore
Conversation
casacore explicitly may depend on readline, not ncurses
casacore optionally depends upon readline, but it's CMakeLists.txt provides no user control over whether or not readline becomes a dependency. As readline is often present by default on systems, it's better for this package to explicitly depend on readline in order to prevent linking to whatever system version of the library happens to be found during the build process. This should be considered a workaround until casacore's CMakeLists.txt is fixed.
Similar to the issues with casacore's readline dependency, casacore's optional dependency on SOFA does not provide the user with a means of controlling the dependency during build time. Unlike the readline library, the SOFA library is unlikely to exist on most systems by default. As the SOFA dependency is only optionally used for testing casacore, requiring it by default is not a good workaround. Until casacore's CMakeLists.txt is fixed, this variant has been removed to avoid unexpected library dependencies in the installed package.
adamjstewart
approved these changes
Jan 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My first Spack PR. I tried to meet the guidelines, but it is unclear whether you'd prefer this broken into multiple PRs, one per commit. Happy to resubmit, if needed.
Note that I have contributed to the upstream casacore package in the past, and I'm currently working on fixes to issues in the casacore build for which I've put in place workarounds in this PR. I hope to be able to follow up with another PR for the casacore package once the upstream is fixed.