Added new hashes for the protobuf and py-protobuf packates.#14546
Merged
adamjstewart merged 2 commits intospack:developfrom Jan 16, 2020
Merged
Added new hashes for the protobuf and py-protobuf packates.#14546adamjstewart merged 2 commits intospack:developfrom
adamjstewart merged 2 commits intospack:developfrom
Conversation
| url = "https://github.com/protocolbuffers/protobuf/archive/v3.10.1.tar.gz" | ||
| root_cmakelists_dir = "cmake" | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
This line is gonna cause flake8 to fail
adamjstewart
approved these changes
Jan 16, 2020
Contributor
Author
|
I didn’t add that line, that was already there.
Brian C. Van Essen
[email protected]
(w) 925-422-9300
(c) 925-290-5470
… On Jan 16, 2020, at 2:00 PM, Adam J. Stewart ***@***.***> wrote:
@adamjstewart commented on this pull request.
In var/spack/repos/builtin/packages/protobuf/package.py:
> @@ -15,7 +15,14 @@ class Protobuf(CMakePackage):
url = "https://github.com/protocolbuffers/protobuf/archive/v3.10.1.tar.gz"
root_cmakelists_dir = "cmake"
+
This line is gonna cause flake8 to fail
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Member
|
But now there are 2 blank lines in a row, and before there was 1... |
Contributor
Author
|
Ah, I fixed it. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.