Use CudaPackage mixin for py-torch#14540
Merged
adamjstewart merged 1 commit intospack:developfrom Jan 16, 2020
Merged
Conversation
This PR adds CudaPackage in order to pick up the cuda/compiler conflicts defined in CudaPackage.
adamjstewart
approved these changes
Jan 16, 2020
Contributor
Author
|
I followed what was done in other packages and added CudaPackage second. However, I think that makes the base class instead. That would affect the following packages:
|
Member
|
@glennpj what makes you think the base class is |
Contributor
Author
|
I am thinking of inheritance order. It probably would never matter, and I could be thinking about it incorrectly, but if we wanted to have the PythonPackage class override something defined in the CudaPackage class I think the order might need to be reversed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds CudaPackage in order to pick up the cuda/compiler conflicts
defined in CudaPackage.