Skip to content

openmpi: swat btl/uct ucx 1.7 bug#14522

Merged
adamjstewart merged 1 commit intospack:developfrom
hppritcha:topic/swap_uct_btl_bug
Jan 18, 2020
Merged

openmpi: swat btl/uct ucx 1.7 bug#14522
adamjstewart merged 1 commit intospack:developfrom
hppritcha:topic/swap_uct_btl_bug

Conversation

@hppritcha
Copy link
Copy Markdown
Contributor

Unfortunately UCX 1.7.0 is appearing in RPMS before it's officially released.
There's a problem with Open MPI 4.0.x where x < 3 and this version of UCX,
namely that the UCT BTL fails to compile.

See open-mpi/ompi#7128

This patch works around the problem by disabling the build of the UCT BTL
for releases 4.0.0 to 4.0.2.

Signed-off-by: Howard Pritchard [email protected]


if spec.satisfies('@4.0.0:4.0.2'):
# uct btl doesn't work with some UCX versions so just disable, fixed in @4.0.3:
config_args.extend(['--enable-mca-no-build=btl-uct'])
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
config_args.extend(['--enable-mca-no-build=btl-uct'])
config_args.append('--enable-mca-no-build=btl-uct')

@adamjstewart
Copy link
Copy Markdown
Member

@hppritcha would you like to add yourself as a maintainer of the Spack package? Just add:

maintainers = ['hppritcha']

below the URL info. This doesn't require you to be a Spack expert, just gives us someone to ping in case someone is having problems building OpenMPI with Spack or wants to update the package themselves.

@hppritcha
Copy link
Copy Markdown
Contributor Author

@hppritcha would you like to add yourself as a maintainer of the Spack package? Just add:

maintainers = ['hppritcha']

below the URL info. This doesn't require you to be a Spack expert, just gives us someone to ping in case someone is having problems building OpenMPI with Spack or wants to update the package themselves.

I'll add myself as maintainer and rework the patch per your suggestion.

@hppritcha hppritcha force-pushed the topic/swap_uct_btl_bug branch from 7a7d9a9 to 35a0634 Compare January 16, 2020 15:25
@hppritcha
Copy link
Copy Markdown
Contributor Author

@adamjstewart check again when you have time

@adamjstewart
Copy link
Copy Markdown
Member

Flake8:

var/spack/repos/builtin/packages/openmpi/package.py:433: [E501] line too long (91 > 79 characters)

Unfortunately UCX 1.7.0 is appearing in RPMS before it's officially released.
There's a problem with Open MPI 4.0.x where x < 3 and this version of UCX,
namely that the UCT BTL fails to compile.

See open-mpi/ompi#7128

This patch works around the problem by disabling the build of the UCT BTL
for releases 4.0.0 to 4.0.2.

add hppritcha (me) as maintainer

Signed-off-by: Howard Pritchard <[email protected]>
@hppritcha hppritcha force-pushed the topic/swap_uct_btl_bug branch from 35a0634 to 46eff76 Compare January 17, 2020 18:36
@adamjstewart adamjstewart merged commit ba22af0 into spack:develop Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants