Skip to content

Added npm and node-js packages#1440

Closed
jppelteret wants to merge 1 commit intospack:developfrom
jppelteret:features/npm_node_js
Closed

Added npm and node-js packages#1440
jppelteret wants to merge 1 commit intospack:developfrom
jppelteret:features/npm_node_js

Conversation

@jppelteret
Copy link
Copy Markdown
Contributor

@jppelteret jppelteret commented Aug 4, 2016

Added npm and node-js packages for use in the Jupyter suite (#1297)

@jppelteret jppelteret mentioned this pull request Aug 4, 2016
Closed
29 tasks
adamjstewart
adamjstewart reviewed Aug 4, 2016
View reviewed changes
var/spack/repos/builtin/packages/node-js/package.py
make('doc')
if self.run_tests:
make('test')
make('test-addons')
Copy link
Copy Markdown
Member

@adamjstewart adamjstewart Aug 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll probably want to build docs and run tests before installation.

@jppelteret jppelteret force-pushed the features/npm_node_js branch from f512a7c to 9aff838 Compare October 23, 2016 07:36
@jppelteret
Copy link
Copy Markdown
Contributor Author

jppelteret commented Oct 25, 2016 •
edited
Loading

@tgamblin @citibeth @adamjstewart Same with this PR please. I was able to install and use both of these packages on OS X 10.11. I have no idea why its not passing tests though. If there are minor changes to be made then I'm willing to do so.

@tgamblin
Copy link
Copy Markdown
Member

tgamblin commented Oct 25, 2016

It's failing on the Python 2.6 support test:

======================================================================
FAIL: test_package_module_compatibility (spack.test.python_version.PythonVersionTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/LLNL/spack/lib/spack/spack/test/python_version.py", line 101, in test_package_module_compatibility
    self.check_python_versions(*self.pyfiles(spack.packages_path))
  File "/home/travis/build/LLNL/spack/lib/spack/spack/test/python_version.py", line 95, in check_python_versions
    self.assertTrue(len(all_issues) == 0)
AssertionError: False is not true
-------------------- >> begin captured stdout << ---------------------
File                                                           Reason
------------------------------------------------------------   --------------------
spack/var/spack/repos/builtin/packages/node-js/package.py:65   subprocess.check_output
spack/var/spack/repos/builtin/packages/node-js/package.py:66   subprocess.check_output

subprocess.check_output is a 2.7 feature and we still support 2.6. You can probably replace the offending lines with this:

if sys.platform == 'darwin':
    libtool = which('libtool')
    assert libtool.command == '/usr/bin/libtool', # ...

@citibeth citibeth mentioned this pull request Oct 25, 2016
Closed
@citibeth citibeth closed this Oct 25, 2016
@jppelteret jppelteret deleted the features/npm_node_js branch October 25, 2016 19:00
olupton pushed a commit to olupton/spack that referenced this pull request Feb 7, 2022
@matz-e
py-rtree: propagate env (spack#1440)
6d7ed81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jppelteret @tgamblin @adamjstewart @citibeth