Skip to content

Feature Proposal : Make All Python Extensions User Configuration Independent#1435

Merged
tgamblin merged 2 commits intospack:developfrom
xjrc:features/setup_py
Oct 6, 2016
Merged

Feature Proposal : Make All Python Extensions User Configuration Independent#1435
tgamblin merged 2 commits intospack:developfrom
xjrc:features/setup_py

Conversation

@xjrc
Copy link
Copy Markdown
Member

@xjrc xjrc commented Aug 3, 2016

This pull request is a continuation of #950 that makes all python extension packages independent of user configuration on installation. For more information about these changes what they entail, please see #950 and #1424.

@xjrc
Copy link
Copy Markdown
Member Author

xjrc commented Sep 9, 2016

I've updated this PR to remove all merge conflicts. @tgamblin: I think that this should be ready.

@xjrc xjrc added feature A feature is missing in Spack python labels Sep 26, 2016
@adamjstewart
Copy link
Copy Markdown
Member

Can you resolve the new merge conflicts and see if any other python() packages have creeped in? @tgamblin Can we get this merged?

@tgamblin
Copy link
Copy Markdown
Member

tgamblin commented Oct 6, 2016

@xjrc: I rebased this for you -- can you update the PR by force pushing features/setup_py from the main repo to your fork? Then I can merge it and you'll be the commit author.

@xjrc
Copy link
Copy Markdown
Member Author

xjrc commented Oct 6, 2016

@tgamblin: Yeah, I'll get around to updating this sometime tomorrow.

@tgamblin
Copy link
Copy Markdown
Member

tgamblin commented Oct 6, 2016

@xjrc: I've rebased it so if you allow maintainers to push into the PR (it's a new checkbox I think) then I can just take care of it.

@xjrc
Copy link
Copy Markdown
Member Author

xjrc commented Oct 6, 2016

@tgamblin: That would be great. I enabled maintainer edits so you should be able to push, but let me know if there are any issues. Thanks!

@tgamblin tgamblin merged commit 82fcc5e into spack:develop Oct 6, 2016
@tgamblin
Copy link
Copy Markdown
Member

tgamblin commented Oct 6, 2016

merged.

krafczyk pushed a commit to krafczyk/spack that referenced this pull request Nov 15, 2016
krafczyk pushed a commit to krafczyk/spack that referenced this pull request Nov 16, 2016
krafczyk pushed a commit to krafczyk/spack that referenced this pull request Nov 16, 2016
krafczyk pushed a commit to krafczyk/spack that referenced this pull request Nov 22, 2016
krafczyk pushed a commit to krafczyk/spack that referenced this pull request Nov 28, 2016
krafczyk pushed a commit to krafczyk/spack that referenced this pull request Nov 30, 2016
krafczyk pushed a commit to krafczyk/spack that referenced this pull request Dec 5, 2016
krafczyk pushed a commit to krafczyk/spack that referenced this pull request Dec 20, 2016
krafczyk pushed a commit to krafczyk/spack that referenced this pull request Jan 3, 2017
krafczyk pushed a commit to krafczyk/spack that referenced this pull request Jan 4, 2017
krafczyk pushed a commit to krafczyk/spack that referenced this pull request Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A feature is missing in Spack python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants