Ignore coverage drop due to lack of macOS tests#14333
Merged
adamjstewart merged 2 commits intospack:developfrom Dec 31, 2019
Merged
Ignore coverage drop due to lack of macOS tests#14333adamjstewart merged 2 commits intospack:developfrom
adamjstewart merged 2 commits intospack:developfrom
Conversation
tgamblin
approved these changes
Dec 31, 2019
Codecov Report
@@ Coverage Diff @@
## develop #14333 +/- ##
===========================================
- Coverage 77.71% 77.46% -0.26%
===========================================
Files 227 227
Lines 27535 27535
Branches 5261 5261
===========================================
- Hits 21400 21329 -71
- Misses 4939 5006 +67
- Partials 1196 1200 +4
Continue to review full report at Codecov.
|
Member
|
@adamjstewart: I'm confused - did this somehow re-enable the codecocv report being posted? That would be annoying. |
Member
Author
|
I'm also confused by that, and by the fact that the test still seems to be failing. Did I put the |
Merged
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Jan 3, 2020
This reverts commit 5b979ae.
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Mar 26, 2020
This reverts commit 5b979ae.
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Apr 23, 2020
This reverts commit 5b979ae.
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
May 9, 2020
This reverts commit 5b979ae.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ever since #13389 dropped macOS tests from PRs, GitHub has been a sea of ❌as every single PR fails its codecov tests. This prevents PRs from being merged on mobile devices, and causes confusion among PR contributors.
A more permanent solution would be to:
This PR is a workaround until that happens.
@alalazo @tgamblin